Skip to content

e2e/nightly tests fixes #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

e2e/nightly tests fixes #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba082e
fixes
vlad-dargel Jun 13, 2023
c4aab50
fix for error
vlad-dargel Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tests/e2e/pageObjects/pub-sub-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@ export class PubSubPage extends InstancePage {
* @param message The message
*/
async publishMessage(channel: string, message: string): Promise<void> {
await t
.click(this.channelNameInput)
.typeText(this.channelNameInput, channel, { replace: true, paste: true })
.click(this.messageInput)
.typeText(this.messageInput, message, { replace: true, paste: true })
.click(this.publishButton);
await t.click(this.channelNameInput);
await t.typeText(this.channelNameInput, channel, { replace: true, paste: true });
await t.click(this.messageInput);
await t.typeText(this.messageInput, message, { replace: true, paste: true });
await t.click(this.publishButton);
}

/**
Expand All @@ -50,6 +49,6 @@ export class PubSubPage extends InstancePage {
async subsribeToChannelAndPublishMessage(channel: string, message: string): Promise<void> {
await t.click(this.subscribeButton);
await this.publishMessage(channel, message);
await t.expect(this.pubSubPageContainer.find('[data-testid^=row]').withText('message').exists).ok('Message is not displayed');
await t.expect((this.pubSubPageContainer.find('[data-testid^=row]').withText('message')).exists).ok('Message is not displayed');
}
}
2 changes: 1 addition & 1 deletion tests/e2e/static-server.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:latest
FROM node:16.15.1-alpine

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/test-data/features-configs/insights-default-remote.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": 0.9,
"version": 1.9,
"features": {
"insightsRecommendations": {
"flag": true,
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/browser/search-capabilities.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ test
await deleteStandaloneDatabaseApi(ossStandaloneV5Config);
})('No RediSearch module message', async t => {
const noRedisearchMessage = 'Looks like RediSearch is not available for this database';
const externalPageLink = 'https://redis.com/try-free/?utm_source=redis&utm_medium=app&utm_campaign=redisinsight_browser_search';
const externalPageLink = 'https://redis.com/try-free/?utm_source=redisinsight&utm_medium=app&utm_campaign=redisinsight_browser_search';

await t.click(browserPage.redisearchModeBtn);
// Verify that user can see message in the dialog when he doesn't have RediSearch module
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/memory-efficiency/recommendations.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,5 @@ test
await t.click(memoryEfficiencyPage.getToTutorialBtnByRecomName(searchJsonRecommendation));
await t.expect(workbenchPage.preselectArea.visible).ok('Workbench Enablement area not opened');
// Verify that REDIS FOR TIME SERIES tutorial expanded
await t.expect((await workbenchPage.getTutorialByName('INTRODUCTION')).visible).ok('INTRODUCTION tutorial is not expanded');
await t.expect(workbenchPage.getTutorialByName('INTRODUCTION').visible).ok('INTRODUCTION tutorial is not expanded');
});
4 changes: 2 additions & 2 deletions tests/e2e/tests/regression/insights/feature-flag.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ test('Verify that default config applied when remote config version is lower', a

const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;

await t.expect(featureVersion).eql(1, 'Config with lowest version applied');
await t.expect(featureVersion).eql(2, 'Config with lowest version applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
});
test('Verify that invaid remote config not applied even if its version is higher than in the default config', async t => {
Expand All @@ -55,7 +55,7 @@ test('Verify that invaid remote config not applied even if its version is higher

const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;

await t.expect(featureVersion).eql(1, 'Config highest version not applied');
await t.expect(featureVersion).eql(2, 'Config highest version not applied');
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
});
test
Expand Down