RI-7693: Change visuals of Pub/Sub #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Frontend unit tests
Test suite run success5239 tests passing in 681 suites. Report generated by 🧪jest coverage report action from 59af60d |
KrumTy
reviewed
Nov 10, 2025
...nsight/ui/src/pages/pub-sub/components/messages-list/EmptyMessagesList/EmptyMessagesList.tsx
Outdated
Show resolved
Hide resolved
...nsight/ui/src/pages/pub-sub/components/messages-list/EmptyMessagesList/EmptyMessagesList.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/messages-list/MessagesListWrapper.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/messages-list/MessagesListWrapper.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/publish-message/PublishMessage.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/publish-message/PublishMessage.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/subscribe-form/SubscribeForm.tsx
Outdated
Show resolved
Hide resolved
valkirilov
previously approved these changes
Nov 10, 2025
redisinsight/ui/src/pages/pub-sub/components/publish-message/PublishMessage.styles.tsx
Outdated
Show resolved
Hide resolved
valkirilov
previously approved these changes
Nov 10, 2025
KrumTy
reviewed
Nov 11, 2025
Collaborator
KrumTy
left a comment
KrumTy
left a comment
There was a problem hiding this comment.
mostly comments about code styles I think we've agreed on (css -> .styles.ts file; gap > spacer)
...nsight/ui/src/pages/pub-sub/components/messages-list/EmptyMessagesList/EmptyMessagesList.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/messages-list/MessagesListWrapper.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/publish-message/PublishMessage.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/publish-message/PublishMessage.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/subscribe-information/SubscribeInformation.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/pub-sub/components/subscribe-information/SubscribeInformation.tsx
Outdated
Show resolved
Hide resolved
KrumTy
approved these changes
Nov 12, 2025
Comment on lines
+31
to
+33
| const channels = subscriptions?.length | ||
| ? subscriptions.map((sub) => sub.channel).join(' ') | ||
| : DEFAULT_SEARCH_MATCH |
Collaborator
There was a problem hiding this comment.
if large array, useMemo might be useful
also same logic is repeated in SubscribeForm.tsx so it might be worth even extracting it to redux (pubsub slice) and do the operation once
Collaborator
Author
There was a problem hiding this comment.
Agree, but will merge it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enhance the design of Pub/Sub page. The PR became huge, but the changes are context-related, so no easy way to introduce them in batches. TL;DR for the changes
<SubscribeForm />Testing
Home screen
So, as you can see from the screenshots, a few conceptual things, aside from the visuals, changed - the status bar at the top is not visible by default.
Messages screen
Here, the status bar at the top has a different UX:
The subscription status is reported differently:
The button indicates the action the user is about to do:
The UX when a message is being sent successfully