RI-7687: fix double scroll issue on the RDI statistics page #5172
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Frontend unit tests
Test suite run success5270 tests passing in 689 suites. Report generated by 🧪jest coverage report action from adde36c |
KrumTy
approved these changes
Nov 11, 2025
valkirilov
approved these changes
Nov 11, 2025
| import { FlexItem } from 'uiSrc/components/base/layout/flex' | ||
|
|
||
| export const RdiInstancePageContentContainer = styled(FlexItem)` | ||
| height: calc(100% - 210px); |
Member
There was a problem hiding this comment.
Tip: You can leave a note in a comment on what exactly 210 is (I guess it's the header + padding + something else), so we know how to calculate it in case we need to update it in the future.
ArtemHoruzhenko
deleted the
fe/feature/RI-7687-adjust-rdi-fix-statistics-double-scroll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixed issue with 2 scrolls appeared for statistics and main container at the same time
Testing
Before
https://github.com/user-attachments/assets/d5780cf8-1190-4666-90d4-5e20d06c176b
After
https://github.com/user-attachments/assets/3923c01c-419a-473d-8d9c-ca6416ca3d9f