-
Notifications
You must be signed in to change notification settings - Fork 419
RI-7681: Make info section fixed + apply scrolling properly #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the wanted scrollable area
Code Coverage - Frontend unit tests
Test suite run success5270 tests passing in 689 suites. Report generated by 🧪jest coverage report action from 4beb981 |
| @@ -0,0 +1,26 @@ | |||
| import styled from 'styled-components' | |||
|
|
|||
| export const FixedWrapper = styled.div` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip: You can use FlexGroup or Col instead of a regular div, so you don't have to define the flex properties on your own.
PS: The same note applies for the other classes bellow, as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Using FlexGroup or Col add a lot of different styles with them, which I try to avoid and make it simple due to the sensitive scenario with the scrolling, that is why I decided to go with this approach.
What
When there is not enough space for the content in the form modals, scroll should be applied.
For the edit forms, the scroll should not apply to the info section + tabs - it should remain fixed. It applies only on the form on each tab.
Testing
Before:
Screen.Recording.2025-11-11.at.17.01.15.mov
After:
Screen.Recording.2025-11-11.at.17.02.54.mov