Skip to content

Conversation

@dantovska
Copy link
Collaborator

What

When there is not enough space for the content in the form modals, scroll should be applied.

For the edit forms, the scroll should not apply to the info section + tabs - it should remain fixed. It applies only on the form on each tab.

Testing

Before:

Screen.Recording.2025-11-11.at.17.01.15.mov

After:

Screen.Recording.2025-11-11.at.17.02.54.mov

@github-actions
Copy link
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.6% 20577/24912
🟡 Branches 67.72% 8776/12960
🟡 Functions 77.27% 5538/7167
🟢 Lines 83.01% 20147/24272

Test suite run success

5270 tests passing in 689 suites.

Report generated by 🧪jest coverage report action from 4beb981

@@ -0,0 +1,26 @@
import styled from 'styled-components'

export const FixedWrapper = styled.div`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: You can use FlexGroup or Col instead of a regular div, so you don't have to define the flex properties on your own.

PS: The same note applies for the other classes bellow, as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Using FlexGroup or Col add a lot of different styles with them, which I try to avoid and make it simple due to the sensitive scenario with the scrolling, that is why I decided to go with this approach.

@dantovska dantovska merged commit 072b349 into main Nov 12, 2025
18 checks passed
@dantovska dantovska deleted the fe/feature/RI-7681-info-section-fixed branch November 12, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants