[no-issue]: optimize FeatureFlagComponent #5176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code Coverage - Frontend unit tests
Test suite run success5270 tests passing in 689 suites. Report generated by 🧪jest coverage report action from 6e44c8f |
KrumTy
requested review from
ArtemHoruzhenko,
DimoHG,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
dantovska
approved these changes
Nov 12, 2025
| ) : ( | ||
| cloneElement(children) | ||
| ) | ||
| return <>{children}</> |
Collaborator
There was a problem hiding this comment.
Suggested change
| return <>{children}</> | |
| return children |
Collaborator
Author
There was a problem hiding this comment.
The fragment is what makes the function’s return type a JSX.Element in a type-safe way. If we drop it, we need to assert types it seems.
pawelangelow
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I noticed FeatureFlagComponent is overcomplicated. There's no need of cloning, arrays, mapping, function calls.
Testing
Components wrapped in FeatureFlagComponent show up correctly