Skip to content

RI-7713: polish import from file forms #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 14, 2025
Merged

RI-7713: polish import from file forms #5186

merged 21 commits into from
Nov 14, 2025

Conversation

@dantovska
Copy link
Collaborator

@dantovska dantovska commented Nov 13, 2025 •
edited
Loading

What

Polish the forms for importing databases from a file.

Import file form:

  • attaching 10MB+ file error message
  • adjust spacing and text color

Invalid file content

  • Replace icon, make it bigger - e.g. import json file with only empty array in it [] -

Import result page

  • fix table borders,
  • Remove colors for success, partial success, failed
  • Make only one section expanded at a time as in the old ui
  • Add padding around the section so box-shadow is not cut off

Testing

Before After
image image
image image
image image
image image
image image
image image
image image
image image

@dantovska dantovska self-assigned this Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

Code Coverage - Frontend unit tests

St.❔
 Category Percentage Covered / Total
🟢 Statements 82.55% 20629/24989
🟡 Branches 67.93% 8820/12983
🟡 Functions 77.27% 5562/7198
🟢 Lines 82.97% 20195/24339

Test suite run success

5311 tests passing in 693 suites.

Report generated by 🧪jest coverage report action from f1ce7d1

@dantovska dantovska force-pushed the fe/feature/RI-7713-polish-import-from-file branch from 1b31f38 to 000120c Compare November 14, 2025 12:42
@dantovska dantovska marked this pull request as ready for review November 14, 2025 12:51
@dantovska
fix the footer button location and sizes
9c1203a
@dantovska
fix import text and spacing between elements
0f3b772
@dantovska
remove info icons next to submit buttons and remove unused import found
8eb893a
@dantovska
Fix footer button sizes and alignment
0f6b7a0
@dantovska
revert the submit button info icon
c0d37b2
@dantovska
finalize styling for main import file db form and error form
cfeffdc
@dantovska
extract import table result constants
97f7cf4
@dantovska
replace hard coded values with defined constants; remove scss styles …
b53162b 
…and files
@dantovska
add sizing for table result index column; add some spacings in the co…
e7f6fa7 
…mponent
@dantovska
add import db result type enum
96c311b
@dantovska
apply proper styling and refactor the results log component
a37a0f1
@dantovska
Ok -> OK
3dcc0fa
@dantovska
add padding to the container instead changing box-shadow -> border
027fbc6
@dantovska
add maxHeight to table result, beyond which a scroll will appear
a045adc
@dantovska
use rems instead of pixels
2056b69
@dantovska
show only sections with items > 0
b114b2a
@dantovska
decrease max table height
c57279e
@dantovska
remove custom margin
3384114
@dantovska
remove unneded collapsible nav title; calculate navState once per ite…
8afbd11 
…m, not three times
@dantovska dantovska force-pushed the fe/feature/RI-7713-polish-import-from-file branch from 000120c to 8afbd11 Compare November 14, 2025 13:18
valkirilov
valkirilov previously approved these changes Nov 14, 2025
View reviewed changes
valkirilov
valkirilov previously approved these changes Nov 14, 2025
View reviewed changes
@dantovska dantovska merged commit c04aac9 into main Nov 14, 2025
20 checks passed
@dantovska dantovska deleted the fe/feature/RI-7713-polish-import-from-file branch November 14, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrumTy KrumTy KrumTy approved these changes

@valkirilov valkirilov valkirilov left review comments

@pawelangelow pawelangelow Awaiting requested review from pawelangelow pawelangelow is a code owner

@ArtemHoruzhenko ArtemHoruzhenko Awaiting requested review from ArtemHoruzhenko ArtemHoruzhenko is a code owner

@pd-redis pd-redis Awaiting requested review from pd-redis pd-redis is a code owner

@DimoHG DimoHG Awaiting requested review from DimoHG DimoHG is a code owner

Assignees

@dantovska dantovska

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dantovska @valkirilov @KrumTy