-
Notifications
You must be signed in to change notification settings - Fork 419
Introduce AI assistant rules and commands #5222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
25d6b10 to
6abfbb7
Compare
Add comprehensive AI rules for code quality, frontend, backend, testing, and workflows. Include commands for commit messages, PR planning/review, and UI testing. - Add .ai/ directory with rules and command documentation - Add .cursor/ and .augument/ integration files - Add GitHub Copilot instructions - Add MCP configuration and example environment file - Update .gitignore for AI-related files
6abfbb7 to
0261f2c
Compare
| "$schema": "https://modelcontextprotocol.io/schema/mcp.json", | ||
| "mcpServers": { | ||
| "git": { | ||
| "command": "uvx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UVX is not available on my system. Maybe some info about how to set it up is also needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check it, we might not need this at all (see this)
| "args": ["mcp-server-git"], | ||
| "description": "Git operations for the RedisInsight repository including status, diff, log, and branch management" | ||
| }, | ||
| "github": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work without token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This MCP config is based on the one used by LangCache.
- so far, I have tested the Attlassian MCP, and it works fine with Jira and Confluence when a token is provided (see
env.mcp.example) - for the rest of the MCPs, I still need to verify them, and also check whether we need them all
.ai/README.md
Outdated
| 4. **Verify your setup:** | ||
| ```bash | ||
| # For Augment users: | ||
| auggie --mcp-config mcp.json "go over all my mcp tools and make sure they work as expected" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a tool we need to have installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current MCP config is based on the one used by LangCache, that's why this example was inherited.
Still, I don't like the idea of forcing you to install a particular tool, so I have replaced the command.
Still, you'll need an Augment account to utilize this feature.
npx @augmentcode/auggie --mcp-config mcp.json "go over all my mcp tools and make sure they work as expected"Additionally, added instructions to verify the MCP server's availability in other tools as well (Cursor and Copilot).
| yarn prettier:fix # Fix formatting | ||
| ``` | ||
|
|
||
| ### Before Every Commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add "on the changed files" to avoid running on the entire codebase
.ai/README.md
Outdated
|
|
||
| ## Redis-Specific Context | ||
|
|
||
| - Support all Redis data types: String, Hash, List, Set, Sorted Set, Stream, JSON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing vector sets 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anymore! 😀
.ai/README.md
Outdated
|
|
||
| ### DON'T: | ||
|
|
||
| - ❌ Use `console.log` (use proper logging) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is proper logging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we don't have any internal way for logging errors, so I have removed the "(use proper logging)" part. Thanks.
Still, all these guidelines were automatically generated based on the LangCache ruleset and our codebase, so everything can be adjusted or removed in the next few iterations.
|
|
||
| ### 1. Ticket Validation | ||
|
|
||
| Verify ticket quality: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically no jira ticket (that I have seen here) meets these?
| ``` | ||
| ```` | ||
|
|
||
| ### API Endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section seems oddly specific to features only, should it be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is not part of the repo. I would add it, but I am afraid it won't be met friendly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove this command if you don't feel like sharing it publicly yet?
4fa20eb to
d006e93
Compare
What
Add comprehensive AI rules for code quality, frontend, backend, testing, and workflows.
Include commands for commit messages, PR planning/review, and UI testing.
.ai/directory with rules and command documentation, serving as a single source of truth.ai/rules and commandsFinal Structure