Skip to content

RI-7838 removed icons from bulk actions #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valkirilov merged 1 commit into from
Nov 28, 2025
Merged

RI-7838 removed icons from bulk actions #5258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions ...sinsight/ui/src/pages/browser/components/bulk-actions/BulkActionsTabs/BulkActionsTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import { DEFAULT_SEARCH_MATCH } from 'uiSrc/constants/api'
import { keysSelector } from 'uiSrc/slices/browser/keys'
import { TabInfo } from 'uiSrc/components/base/layout/tabs'
import { Text } from 'uiSrc/components/base/text'
import { RiIcon } from 'uiSrc/components/base/icons'
import { Row } from 'uiSrc/components/base/layout/flex'

import { StyledTabs } from './BulkActionsTabs.styles'

Expand Down Expand Up @@ -56,22 +54,12 @@ const BulkActionsTabs = (props: Props) => {
() => [
{
value: BulkActionsType.Delete,
label: (
<Row align="center" gap="m" grow={false}>
<RiIcon type="DeleteIcon" />
<Text size="XS">Delete Keys</Text>
</Row>
),
label: <Text size="S">Delete Keys</Text>,
Copy link
Member

@valkirilov valkirilov Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Actually, changing the text size also makes it look better.

Image

content: null,
},
{
value: BulkActionsType.Upload,
label: (
<Row align="center" gap="m" grow={false}>
<RiIcon type="BulkUploadIcon" size="M" />
<Text size="XS">Upload Data</Text>
</Row>
),
label: <Text size="S">Upload Data</Text>,
content: null,
},
],
Expand Down
Loading