Skip to content

Added test ids for e2e tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Added test ids for e2e tests #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion redisinsight/ui/src/components/navigation-menu/NavigationMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const NavigationMenu = () => {
</>
)}
>
<div className={styles.popover}>
<div className={styles.popover} data-testid="help-center">
<EuiTitle size="xs">
<span>Help Center</span>
</EuiTitle>
Expand All @@ -173,6 +173,7 @@ const NavigationMenu = () => {
className={styles.helpMenuItemLink}
href="https://github.com/RedisInsight/RedisInsight/issues"
target="_blank"
data-testid="submit-bug-btn"
>
<EuiIcon type="flag" size="xl" />
<EuiSpacer size="s" />
Expand All @@ -185,6 +186,7 @@ const NavigationMenu = () => {
<EuiFlexItem
className={styles.helpMenuItem}
onClick={() => onKeyboardShortcutClick()}
data-testid="shortcuts-btn"
>
<div className={styles.helpMenuItemLink}>
<EuiIcon type="keyboardShortcut" size="xl" />
Expand All @@ -206,6 +208,7 @@ const NavigationMenu = () => {
onClick={onClickReleaseNotes}
href="https://docs.redis.com/staging/release-ri-v2.0/ri/release-notes/"
target="_blank"
data-testid="release-notes-btn"
>
<div className={cx({ [styles.helpMenuItemNotified]: isReleaseNotesViewed === false })}>
<EuiIcon type="package" size="xl" />
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/shortcuts-flyout/ShortcutsFlyout.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('ShortcutsFlyout', () => {

SHORTCUTS.forEach((group: ShortcutGroup) => {
expect(
document.querySelector(`[data-test-subj="shortcut-title-${group.name}"]`)
document.querySelector(`[data-test-subj="shortcuts-section-${group.name}"]`)
).toBeInTheDocument()
})
})
Expand Down
5 changes: 3 additions & 2 deletions redisinsight/ui/src/components/shortcuts-flyout/ShortcutsFlyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const ShortcutsFlyout = () => {

const ShortcutsTable = ({ name, items }: ShortcutGroup) => (
<div key={name}>
<EuiTitle size="xxs" data-test-subj={`shortcut-title-${name}`}>
<EuiTitle size="xxs" data-test-subj={`shortcuts-section-${name}`}>
<h6>{name}</h6>
</EuiTitle>
<EuiSpacer size="m" />
Expand All @@ -55,9 +55,10 @@ const ShortcutsFlyout = () => {
ownFocus
size="538px"
onClose={() => dispatch(setShortcutsFlyoutState(false))}
data-test-subj="shortcuts-flyout"
>
<EuiFlyoutBody>
<EuiTitle size="s" className={styles.title}>
<EuiTitle size="s" className={styles.title} data-testid="shortcuts-title">
<h4>Shortcuts</h4>
</EuiTitle>
<EuiSpacer size="m" />
Expand Down