-
Notifications
You must be signed in to change notification settings - Fork 19
Add new_session field to WorkingMemoryResponse to indicate if a session was created #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0b3d878
Add new_session field to WorkingMemoryResponse for backwards compatib…
abrookins d02e720
Update examples and docs to use tuple return from get_or_create_worki…
abrookins 0f0957a
Fix test_session_lifecycle to handle new backwards-compatible behavior
abrookins f17b5ce
Redesign session management with proper REST semantics and version-aw…
abrookins 5696814
Simplify session response fields by removing redundant new_session in…
abrookins b943664
Consolidate MODEL_CONFIGS to fix embedding dimension configuration
abrookins ddd747d
Fix ModelConfig attribute access in vectorstore factory
claude[bot] ccb97ff
Simplify vectorstore factory to only support Pydantic ModelConfig obj…
claude[bot] c2b2ba2
Replace print statements with logging in client.py
claude[bot] 7f73e54
Fix code formatting with ruff format
claude[bot] cde631a
Fix code formatting issues found by pre-commit hooks
claude[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception handling assumes the GET request will return a 404 for non-existent sessions, but based on the API changes in
agent_memory_server/api.py, the GET endpoint now creates empty sessions for backwards compatibility and should never return 404. This logic needs to be updated to match the new API behavior.