Skip to content

Conversation

@abrookins
Copy link
Collaborator

Changes

  • Changed the default value of optimize_query parameter from True to False in the client's search_long_term_memory function
  • Updated tests to verify the new default behavior
  • Bumped client version from 0.12.5 to 0.12.6

Rationale

This change reduces unnecessary LLM calls for query optimization by defaulting to False. Users can still explicitly enable optimization when needed by passing optimize_query=True.

Testing

  • All existing tests pass
  • Updated test test_search_long_term_memory_with_optimize_query_default_false to verify the new default
  • Updated test test_search_long_term_memory_with_optimize_query_true_explicit to verify explicit override still works

Reduces unnecessary LLM calls for query optimization by defaulting to False.
Users can still explicitly enable optimization when needed.
Copilot AI review requested due to automatic review settings October 3, 2025 17:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the default behavior of query optimization in the client's search function to reduce unnecessary LLM calls. The default value of optimize_query is changed from True to False, allowing users to explicitly enable optimization when needed.

  • Changed default value of optimize_query parameter from True to False in client's search_long_term_memory function
  • Updated corresponding test cases to verify the new default behavior and explicit override functionality
  • Incremented client version from 0.12.5 to 0.12.6

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
agent-memory-client/agent_memory_client/client.py Changed default value of optimize_query parameter from True to False
tests/test_client_api.py Updated test names, comments, and assertions to reflect new default behavior
agent-memory-client/agent_memory_client/init.py Bumped version from 0.12.5 to 0.12.6

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@abrookins abrookins merged commit 08b51f2 into main Oct 3, 2025
12 checks passed
@abrookins abrookins deleted the change-optimize-query-default-to-false branch October 3, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants