Remove deprecated ensure_search_index_exists function #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VectorStore adapter creates the index automatically when needed, making this function unnecessary. Removed all calls to it from: - API server startup (main.py) - MCP server startup (mcp.py) - CLI commands (cli.py) - Long-term memory compaction (long_term_memory.py) Updated rebuild_index CLI command to use the vectorstore adapter directly. Updated tests to match new behavior.
abrookins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The codebase had a deprecated ensure_search_index_exists() function that was still being called in multiple places, even though its own docstring said 'The VectorStore adapter now handles index creation automatically.'
This function was causing issues:
Solution
Removed the deprecated function entirely and all calls to it:
The index is now created automatically by LangChain Redis when documents are first added (via the create_index_if_not_exists parameter which defaults to True).
Testing