Skip to content

Conversation

@ZdravkoDonev-redis
Copy link
Collaborator

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for a known high-availability upgrade issue when moving RDI from versions below 1.8.0 to 1.8.0 or higher, including symptoms and a manual-cluster-ID workaround.

  • Added a Known Issues section in the RDI 1.8.0 release notes describing the HA lock upgrade problem and workaround.
  • Inserted a warning block in the upgrade guide with the same issue details and remediation steps.
  • Specified how to edit the configmap to set a unique RDI_CLUSTER_ID.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
content/.../release-notes/rdi-1-8-0.md Documented HA upgrade issue, symptoms, and configmap workaround
content/.../installation/upgrade.md Added warning for VM HA upgrade issue and manual cluster ID workaround
Comments suppressed due to low confidence (1)

content/integrate/redis-data-integration/release-notes/rdi-1-8-0.md:95

  • [nitpick] In this paragraph, mix of "instances" and later "clusters" may confuse readers. Consider using a single term (e.g., always "instances").
When upgrading from RDI < 1.8.0 to RDI >= 1.8.0 in an HA setup, both RDI instances may incorrectly consider themselves active after the upgrade. This occurs because the upgrade process doesn't update the `rdi:ha:lock` value from the legacy `cluster-1` identifier, causing both clusters to assume they are the active cluster.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion (Copilot already suggested the other one I was going to add), but otherwise LGTM.

Copy link
Collaborator

@yaronp68 yaronp68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge stoyan propsals

andy-stark-redis and others added 4 commits July 1, 2025 15:57
Co-authored-by: Stoyan Rachev <stoyanr@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@andy-stark-redis andy-stark-redis self-requested a review July 1, 2025 14:59
@andy-stark-redis andy-stark-redis merged commit 69c4e2f into main Jul 1, 2025
4 of 5 checks passed
@andy-stark-redis andy-stark-redis deleted the RDSC-3785-add-note-for-rdi-1.8.0-upgrade-known-issue branch July 1, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants