-
Notifications
You must be signed in to change notification settings - Fork 277
DEV: migrate cmd compat. info. to individual cmd pages #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cmilesb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed a few of the Cluster management commands and some of the Connection management commands, and they looked good and correct.
Thank you, @cmilesb! |
kaitlynmichael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked about a dozen and they were all correct.
Thank you, @kaitlynmichael! |
andy-stark-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the ones below and they all looked OK to me.
BGREWRITEAOF
CONFIG GET
EVAL
FLUSHDB
FT.SYNUPDATE
GEOSEARCHSTORE
HKEYS
JSON.CLEAR
LATENCY HISTOGRAM
LMOVE
MODULE LOAD
QUIT
SETBIT
SMISMEMBER
TOPK.LIST
TOUCH
TS.RANGE
VADD
XPENDING
ZREMRANGEBYSCORE
|
Thank you, @andy-stark-redis! |
This is a huge PR. It would be very helpful if reviewers could look at a random sample of say 5-10 commands and compare with the info in the following places:
I will also be looking at all ~500 pages. 😧
Also includes changes to layouts/commands/single.html to add a link at the top of each command page.