Skip to content

FLUSH commands and functions #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2024
Merged

FLUSH commands and functions #762

merged 3 commits into from
Oct 15, 2024

Conversation

@LiorKogan
Copy link
Member

@LiorKogan LiorKogan commented Oct 14, 2024 •
edited
Loading

Added a note: functions are not deleted.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

Staging links:
https://redis.io/docs/staging/flush-commands-and-functions/commands/flushall/
https://redis.io/docs/staging/flush-commands-and-functions/commands/flushdb/

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LiorKogan LiorKogan requested a review from dwdougherty October 14, 2024 09:00
@oranagra
Copy link
Member

@LiorKogan do you expect me to read the diff and somehow figure out what was changed in that long line and why??
please add a description to the PR to make it easier.

@LiorKogan
Copy link
Member Author

LiorKogan commented Oct 14, 2024 •
edited
Loading

Nothing was changed in that [not so] long line. I changed "note" to "notes" and added a new note - functions are not deleted.

@dwdougherty dwdougherty self-assigned this Oct 15, 2024
dwdougherty
dwdougherty requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor issues.

dwdougherty
dwdougherty approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@dwdougherty dwdougherty merged commit a8ea319 into main Oct 15, 2024
4 of 5 checks passed
@dwdougherty dwdougherty deleted the flush-commands-and-functions branch October 15, 2024 15:16
kaitlynmichael pushed a commit that referenced this pull request Oct 18, 2024
@LiorKogan @dwdougherty @kaitlynmichael
FLUSH commands and functions (#762)
5567342 
* FLUSH commands and functions

* Update index.md

* Apply suggestions from code review

---------

Co-authored-by: David Dougherty <david.dougherty@redis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@oranagra oranagra oranagra approved these changes

@dmaier-redislabs dmaier-redislabs Awaiting requested review from dmaier-redislabs

Assignees

@dwdougherty dwdougherty

Labels

dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LiorKogan @CLAassistant @oranagra @dwdougherty