Skip to content

DOC-4384 removed spurious info on RDI Oracle prep page #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2024
Merged

DOC-4384 removed spurious info on RDI Oracle prep page #787

merged 3 commits into from
Oct 21, 2024

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Oct 21, 2024 •
edited by atlassian bot
Loading

@andy-stark-redis andy-stark-redis requested a review from a team October 21, 2024 08:47
@andy-stark-redis andy-stark-redis self-assigned this Oct 21, 2024
@github-actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4384-rdi-oracle-info-wrong/integrate/redis-data-integration/data-pipelines/prepare-dbs/oracle

@loriotpiroloriol
Copy link
Contributor

That change is not correct - the section about supplemental logging needs to be kept, but it must be made clear that this applies to all deployment types, not just AWS RDS. Maybe introduce a separate numbered item Supplemental Logging?

@dwdougherty
Copy link
Collaborator

Hi @andy-stark-redis . Is the heading "Configure Amazon RDS for Oracle" a separate step? It looks like maybe it should be.

@andy-stark-redis
Copy link
Contributor Author

Hi @andy-stark-redis . Is the heading "Configure Amazon RDS for Oracle" a separate step? It looks like maybe it should be.

@dwdougherty Hi. No, it is a subheading of step 1. The note at the top alerts you that the instructions for this step are different for Amazon RDS.

dwdougherty
dwdougherty approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andy-stark-redis
Copy link
Contributor Author

Thanks, @dwdougherty !

@andy-stark-redis andy-stark-redis merged commit b627496 into main Oct 21, 2024
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4384-rdi-oracle-info-wrong branch October 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

Assignees

@andy-stark-redis andy-stark-redis

Labels

rdi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andy-stark-redis @loriotpiroloriol @dwdougherty