Skip to content

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Dec 2, 2024

DOC-4600

Couple of things to check:

  • The group is called rdi-aurora-pg from the start, but the last screenshot from the original Confluence page had gvb-aurora-pg instead. I've done a bit of image editing to change this to rdi-aurora-pg - hopefully this was the correct thing to do.
  • Does the Additional Information/DB Cluster parameter group have a Save button on the real AWS page but it's just not in the screenshot?

@andy-stark-redis andy-stark-redis requested a review from a team December 2, 2024 11:12
@andy-stark-redis andy-stark-redis self-assigned this Dec 2, 2024
@andy-stark-redis andy-stark-redis marked this pull request as ready for review December 2, 2024 11:48
Comment on lines +35 to +39
| **Parameter group name** | rdi-aurora-pg |
| **Description** | Enable logical replication for RDI |
| **Engine Type** | Aurora PostgreSQL |
| **Parameter group family** | aurora-postgresql15 |
| **Type** | DB Cluster Parameter Group |
Copy link
Collaborator

@dwdougherty dwdougherty Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the values in this table, maybe choose a different rendering for values that appear in the linked images. For example, use a code for rdi-aurora-pg, as you do further down on this page; use bold for "DB Cluster Parameter Group" because it is a UI element; etc.

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment that I'll leave to you to decide whether or not to include.

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this, Andy!

@andy-stark-redis andy-stark-redis merged commit f6eee75 into main Dec 11, 2024
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4600-rdi-aws-aur-pgsql branch December 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants