Skip to content

Commit 5776216

Browse files
committed
Cleanup
1 parent 2c55c0b commit 5776216

File tree

3 files changed

+43
-44
lines changed

3 files changed

+43
-44
lines changed

command.go

Lines changed: 34 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@ type Cmder interface {
1717
Args() []interface{}
1818
stringArg(int) string
1919

20-
readReply(rd *proto.Reader) error
21-
setErr(error)
22-
2320
readTimeout() *time.Duration
21+
readReply(rd *proto.Reader) error
2422

23+
setErr(error)
2524
Err() error
2625
}
2726

@@ -92,31 +91,31 @@ func cmdFirstKeyPos(cmd Cmder, info *CommandInfo) int {
9291
//------------------------------------------------------------------------------
9392

9493
type baseCmd struct {
95-
_args []interface{}
96-
err error
94+
args []interface{}
95+
err error
9796

9897
_readTimeout *time.Duration
9998
}
10099

101100
var _ Cmder = (*Cmd)(nil)
102101

103102
func (cmd *baseCmd) Name() string {
104-
if len(cmd._args) == 0 {
103+
if len(cmd.args) == 0 {
105104
return ""
106105
}
107106
// Cmd name must be lower cased.
108107
return internal.ToLower(cmd.stringArg(0))
109108
}
110109

111110
func (cmd *baseCmd) Args() []interface{} {
112-
return cmd._args
111+
return cmd.args
113112
}
114113

115114
func (cmd *baseCmd) stringArg(pos int) string {
116-
if pos < 0 || pos >= len(cmd._args) {
115+
if pos < 0 || pos >= len(cmd.args) {
117116
return ""
118117
}
119-
s, _ := cmd._args[pos].(string)
118+
s, _ := cmd.args[pos].(string)
120119
return s
121120
}
122121

@@ -146,7 +145,7 @@ type Cmd struct {
146145

147146
func NewCmd(args ...interface{}) *Cmd {
148147
return &Cmd{
149-
baseCmd: baseCmd{_args: args},
148+
baseCmd: baseCmd{args: args},
150149
}
151150
}
152151

@@ -303,7 +302,7 @@ var _ Cmder = (*SliceCmd)(nil)
303302

304303
func NewSliceCmd(args ...interface{}) *SliceCmd {
305304
return &SliceCmd{
306-
baseCmd: baseCmd{_args: args},
305+
baseCmd: baseCmd{args: args},
307306
}
308307
}
309308

@@ -341,7 +340,7 @@ var _ Cmder = (*StatusCmd)(nil)
341340

342341
func NewStatusCmd(args ...interface{}) *StatusCmd {
343342
return &StatusCmd{
344-
baseCmd: baseCmd{_args: args},
343+
baseCmd: baseCmd{args: args},
345344
}
346345
}
347346

@@ -374,7 +373,7 @@ var _ Cmder = (*IntCmd)(nil)
374373

375374
func NewIntCmd(args ...interface{}) *IntCmd {
376375
return &IntCmd{
377-
baseCmd: baseCmd{_args: args},
376+
baseCmd: baseCmd{args: args},
378377
}
379378
}
380379

@@ -407,7 +406,7 @@ var _ Cmder = (*IntSliceCmd)(nil)
407406

408407
func NewIntSliceCmd(args ...interface{}) *IntSliceCmd {
409408
return &IntSliceCmd{
410-
baseCmd: baseCmd{_args: args},
409+
baseCmd: baseCmd{args: args},
411410
}
412411
}
413412

@@ -451,7 +450,7 @@ var _ Cmder = (*DurationCmd)(nil)
451450

452451
func NewDurationCmd(precision time.Duration, args ...interface{}) *DurationCmd {
453452
return &DurationCmd{
454-
baseCmd: baseCmd{_args: args},
453+
baseCmd: baseCmd{args: args},
455454
precision: precision,
456455
}
457456
}
@@ -497,7 +496,7 @@ var _ Cmder = (*TimeCmd)(nil)
497496

498497
func NewTimeCmd(args ...interface{}) *TimeCmd {
499498
return &TimeCmd{
500-
baseCmd: baseCmd{_args: args},
499+
baseCmd: baseCmd{args: args},
501500
}
502501
}
503502

@@ -547,7 +546,7 @@ var _ Cmder = (*BoolCmd)(nil)
547546

548547
func NewBoolCmd(args ...interface{}) *BoolCmd {
549548
return &BoolCmd{
550-
baseCmd: baseCmd{_args: args},
549+
baseCmd: baseCmd{args: args},
551550
}
552551
}
553552

@@ -601,7 +600,7 @@ var _ Cmder = (*StringCmd)(nil)
601600

602601
func NewStringCmd(args ...interface{}) *StringCmd {
603602
return &StringCmd{
604-
baseCmd: baseCmd{_args: args},
603+
baseCmd: baseCmd{args: args},
605604
}
606605
}
607606

@@ -691,7 +690,7 @@ var _ Cmder = (*FloatCmd)(nil)
691690

692691
func NewFloatCmd(args ...interface{}) *FloatCmd {
693692
return &FloatCmd{
694-
baseCmd: baseCmd{_args: args},
693+
baseCmd: baseCmd{args: args},
695694
}
696695
}
697696

@@ -724,7 +723,7 @@ var _ Cmder = (*StringSliceCmd)(nil)
724723

725724
func NewStringSliceCmd(args ...interface{}) *StringSliceCmd {
726725
return &StringSliceCmd{
727-
baseCmd: baseCmd{_args: args},
726+
baseCmd: baseCmd{args: args},
728727
}
729728
}
730729

@@ -774,7 +773,7 @@ var _ Cmder = (*BoolSliceCmd)(nil)
774773

775774
func NewBoolSliceCmd(args ...interface{}) *BoolSliceCmd {
776775
return &BoolSliceCmd{
777-
baseCmd: baseCmd{_args: args},
776+
baseCmd: baseCmd{args: args},
778777
}
779778
}
780779

@@ -817,7 +816,7 @@ var _ Cmder = (*StringStringMapCmd)(nil)
817816

818817
func NewStringStringMapCmd(args ...interface{}) *StringStringMapCmd {
819818
return &StringStringMapCmd{
820-
baseCmd: baseCmd{_args: args},
819+
baseCmd: baseCmd{args: args},
821820
}
822821
}
823822

@@ -866,7 +865,7 @@ var _ Cmder = (*StringIntMapCmd)(nil)
866865

867866
func NewStringIntMapCmd(args ...interface{}) *StringIntMapCmd {
868867
return &StringIntMapCmd{
869-
baseCmd: baseCmd{_args: args},
868+
baseCmd: baseCmd{args: args},
870869
}
871870
}
872871

@@ -915,7 +914,7 @@ var _ Cmder = (*StringStructMapCmd)(nil)
915914

916915
func NewStringStructMapCmd(args ...interface{}) *StringStructMapCmd {
917916
return &StringStructMapCmd{
918-
baseCmd: baseCmd{_args: args},
917+
baseCmd: baseCmd{args: args},
919918
}
920919
}
921920

@@ -963,7 +962,7 @@ var _ Cmder = (*XMessageSliceCmd)(nil)
963962

964963
func NewXMessageSliceCmd(args ...interface{}) *XMessageSliceCmd {
965964
return &XMessageSliceCmd{
966-
baseCmd: baseCmd{_args: args},
965+
baseCmd: baseCmd{args: args},
967966
}
968967
}
969968

@@ -1054,7 +1053,7 @@ var _ Cmder = (*XStreamSliceCmd)(nil)
10541053

10551054
func NewXStreamSliceCmd(args ...interface{}) *XStreamSliceCmd {
10561055
return &XStreamSliceCmd{
1057-
baseCmd: baseCmd{_args: args},
1056+
baseCmd: baseCmd{args: args},
10581057
}
10591058
}
10601059

@@ -1123,7 +1122,7 @@ var _ Cmder = (*XPendingCmd)(nil)
11231122

11241123
func NewXPendingCmd(args ...interface{}) *XPendingCmd {
11251124
return &XPendingCmd{
1126-
baseCmd: baseCmd{_args: args},
1125+
baseCmd: baseCmd{args: args},
11271126
}
11281127
}
11291128

@@ -1222,7 +1221,7 @@ var _ Cmder = (*XPendingExtCmd)(nil)
12221221

12231222
func NewXPendingExtCmd(args ...interface{}) *XPendingExtCmd {
12241223
return &XPendingExtCmd{
1225-
baseCmd: baseCmd{_args: args},
1224+
baseCmd: baseCmd{args: args},
12261225
}
12271226
}
12281227

@@ -1296,7 +1295,7 @@ var _ Cmder = (*ZSliceCmd)(nil)
12961295

12971296
func NewZSliceCmd(args ...interface{}) *ZSliceCmd {
12981297
return &ZSliceCmd{
1299-
baseCmd: baseCmd{_args: args},
1298+
baseCmd: baseCmd{args: args},
13001299
}
13011300
}
13021301

@@ -1348,7 +1347,7 @@ var _ Cmder = (*ZWithKeyCmd)(nil)
13481347

13491348
func NewZWithKeyCmd(args ...interface{}) *ZWithKeyCmd {
13501349
return &ZWithKeyCmd{
1351-
baseCmd: baseCmd{_args: args},
1350+
baseCmd: baseCmd{args: args},
13521351
}
13531352
}
13541353

@@ -1408,7 +1407,7 @@ var _ Cmder = (*ScanCmd)(nil)
14081407

14091408
func NewScanCmd(process func(cmd Cmder) error, args ...interface{}) *ScanCmd {
14101409
return &ScanCmd{
1411-
baseCmd: baseCmd{_args: args},
1410+
baseCmd: baseCmd{args: args},
14121411
process: process,
14131412
}
14141413
}
@@ -1460,7 +1459,7 @@ var _ Cmder = (*ClusterSlotsCmd)(nil)
14601459

14611460
func NewClusterSlotsCmd(args ...interface{}) *ClusterSlotsCmd {
14621461
return &ClusterSlotsCmd{
1463-
baseCmd: baseCmd{_args: args},
1462+
baseCmd: baseCmd{args: args},
14641463
}
14651464
}
14661465

@@ -1577,7 +1576,7 @@ var _ Cmder = (*GeoLocationCmd)(nil)
15771576

15781577
func NewGeoLocationCmd(q *GeoRadiusQuery, args ...interface{}) *GeoLocationCmd {
15791578
return &GeoLocationCmd{
1580-
baseCmd: baseCmd{_args: geoLocationArgs(q, args...)},
1579+
baseCmd: baseCmd{args: geoLocationArgs(q, args...)},
15811580
q: q,
15821581
}
15831582
}
@@ -1721,7 +1720,7 @@ var _ Cmder = (*GeoPosCmd)(nil)
17211720

17221721
func NewGeoPosCmd(args ...interface{}) *GeoPosCmd {
17231722
return &GeoPosCmd{
1724-
baseCmd: baseCmd{_args: args},
1723+
baseCmd: baseCmd{args: args},
17251724
}
17261725
}
17271726

@@ -1795,7 +1794,7 @@ var _ Cmder = (*CommandsInfoCmd)(nil)
17951794

17961795
func NewCommandsInfoCmd(args ...interface{}) *CommandsInfoCmd {
17971796
return &CommandsInfoCmd{
1798-
baseCmd: baseCmd{_args: args},
1797+
baseCmd: baseCmd{args: args},
17991798
}
18001799
}
18011800

iterator.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ func (it *ScanIterator) Next() bool {
4343
}
4444

4545
// Fetch next page.
46-
if it.cmd._args[0] == "scan" {
47-
it.cmd._args[1] = it.cmd.cursor
46+
if it.cmd.args[0] == "scan" {
47+
it.cmd.args[1] = it.cmd.cursor
4848
} else {
49-
it.cmd._args[2] = it.cmd.cursor
49+
it.cmd.args[2] = it.cmd.cursor
5050
}
5151

5252
err := it.cmd.process(it.cmd)

redis.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func (hs hooks) process(
4646

4747
cmdErr := fn(ctx, cmd)
4848

49-
_, err = hs.afterProcess(ctx, cmd)
49+
err = hs.afterProcess(ctx, cmd)
5050
if err != nil {
5151
return err
5252
}
@@ -65,15 +65,15 @@ func (hs hooks) beforeProcess(ctx context.Context, cmd Cmder) (context.Context,
6565
return ctx, nil
6666
}
6767

68-
func (hs hooks) afterProcess(ctx context.Context, cmd Cmder) (context.Context, error) {
68+
func (hs hooks) afterProcess(ctx context.Context, cmd Cmder) error {
6969
var firstErr error
7070
for _, h := range hs.hooks {
7171
err := h.AfterProcess(ctx, cmd)
7272
if err != nil && firstErr == nil {
7373
firstErr = err
7474
}
7575
}
76-
return ctx, firstErr
76+
return firstErr
7777
}
7878

7979
func (hs hooks) processPipeline(
@@ -86,7 +86,7 @@ func (hs hooks) processPipeline(
8686

8787
cmdsErr := fn(ctx, cmds)
8888

89-
_, err = hs.afterProcessPipeline(ctx, cmds)
89+
err = hs.afterProcessPipeline(ctx, cmds)
9090
if err != nil {
9191
return err
9292
}
@@ -105,15 +105,15 @@ func (hs hooks) beforeProcessPipeline(ctx context.Context, cmds []Cmder) (contex
105105
return ctx, nil
106106
}
107107

108-
func (hs hooks) afterProcessPipeline(ctx context.Context, cmds []Cmder) (context.Context, error) {
108+
func (hs hooks) afterProcessPipeline(ctx context.Context, cmds []Cmder) error {
109109
var firstErr error
110110
for _, h := range hs.hooks {
111111
err := h.AfterProcessPipeline(ctx, cmds)
112112
if err != nil && firstErr == nil {
113113
firstErr = err
114114
}
115115
}
116-
return ctx, firstErr
116+
return firstErr
117117
}
118118

119119
//------------------------------------------------------------------------------

0 commit comments

Comments
 (0)