internal/pool: exit conn pool fast #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL makes ConnPool exit immediately when the client is closed. Fixes #1029
|
@vmihailenco No idea how the test failed in travis-ci. The CL passes all tests locally. |
vmihailenco
reviewed
Sep 7, 2019
Note that this CL does not eliminates p.closed() check to avoid ticker case being executed accidentally. Fixes #1029
vmihailenco
reviewed
Sep 8, 2019
vmihailenco
reviewed
Sep 8, 2019
vmihailenco
reviewed
Sep 8, 2019
vmihailenco
reviewed
Sep 8, 2019
vmihailenco
reviewed
Sep 8, 2019
| case <-ticker.C: | ||
| // It is possible that ticker and closedCh arrive together, | ||
| // and select pseudo-randomly pick ticker case, we double | ||
| // check here to prevent being executed after closed. |
There was a problem hiding this comment.
Good call - thanks for adding the comment!
|
Thanks! |
vmihailenco
pushed a commit
that referenced
this pull request
Mar 11, 2020
* internal/pool: exit conn pool reaper fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes ConnPool exit immediately when the client is closed.
Fixes #1029