Skip to content

feat: add support for time.Duration write and scan #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2021
Merged

feat: add support for time.Duration write and scan #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f1b74e
feat: add support for time.Duration write and scan
Pyrodash Oct 21, 2021
a2a463b
test: add test case for setting and scanning durations
Pyrodash Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/proto/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,13 @@ func Scan(b []byte, v interface{}) error {
var err error
*v, err = time.Parse(time.RFC3339Nano, util.BytesToString(b))
return err
case *time.Duration:
n, err := util.ParseInt(b, 10, 64)
if err != nil {
return err
}
*v = time.Duration(n)
return nil
case encoding.BinaryUnmarshaler:
return v.UnmarshalBinary(b)
default:
Expand Down
2 changes: 2 additions & 0 deletions internal/proto/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ func (w *Writer) WriteArg(v interface{}) error {
case time.Time:
w.numBuf = v.AppendFormat(w.numBuf[:0], time.RFC3339Nano)
return w.bytes(w.numBuf)
case time.Duration:
return w.int(v.Nanoseconds())
case encoding.BinaryMarshaler:
b, err := v.MarshalBinary()
if err != nil {
Expand Down
12 changes: 12 additions & 0 deletions redis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,18 @@ var _ = Describe("Client", func() {
Expect(tm2).To(BeTemporally("==", tm))
})

It("should set and scan durations", func() {
duration := 10 * time.Minute
err := client.Set(ctx, "duration", duration, 0).Err()
Expect(err).NotTo(HaveOccurred())

var duration2 time.Duration
err = client.Get(ctx, "duration").Scan(&duration2)
Expect(err).NotTo(HaveOccurred())

Expect(duration2).To(Equal(duration))
})

It("should Conn", func() {
err := client.Conn(ctx).Get(ctx, "this-key-does-not-exist").Err()
Expect(err).To(Equal(redis.Nil))
Expand Down