Skip to content

Conversation

@ggivo
Copy link
Collaborator

@ggivo ggivo commented Oct 10, 2025

Update 'Installing optional dependencies' documentation in https://redis.github.io/jedis/failover/

resilience4j-all is also required when using the Failover API (MultiDbClient), because of usage of Decorator

@ggivo ggivo requested a review from Copilot October 10, 2025 10:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the failover documentation to include the required resilience4j-all dependency for using the Failover API (MultiDbClient), which is needed because the code uses the Decorator class.

  • Added documentation for the resilience4j-all dependency requirement
  • Clarified dependency requirements for the Failover API usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Test Results

   279 files  ±0    279 suites  ±0   11m 20s ⏱️ -1s
10 063 tests ±0  9 007 ✅ ±0  1 056 💤 ±0  0 ❌ ±0 
 2 701 runs  ±0  2 701 ✅ ±0      0 💤 ±0  0 ❌ ±0 

Results for commit ce55829. ± Comparison against base commit 9a129e7.

♻️ This comment has been updated with latest results.

@ggivo ggivo marked this pull request as ready for review October 10, 2025 10:45
@ggivo ggivo merged commit eea01d2 into master Oct 10, 2025
11 checks passed
@ggivo ggivo deleted the ggico/doc-failover-required-dependency branch October 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants