Fix srandmember return type from Set to List #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication According to http://redis.io/commands/srandmember , if `count` is positive, results are distinct. But, `count` is negative, it allows results contain same element multiple items.
Collaborator
|
Thanks for the PR. This is a breaking API change so I'm going to apply the changes to |
mp911de
pushed a commit
that referenced
this pull request
Aug 11, 2016
…ication #330 According to http://redis.io/commands/srandmember , if `count` is positive, results are distinct. But, `count` is negative, it allows results contain same element multiple items.
Collaborator
|
Thanks a lot. That's merged with cc428c7. |
mp911de
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
You have read the contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
…ication
According to http://redis.io/commands/srandmember ,
if
countis positive, results are distinct.But,
countis negative, it allows results contain same element multiple items.