tests: setup GitHub Actions to replace Travis #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de_redis into @salakar/gh-actions
Salakar
changed the title
BridgeAR
reviewed
Feb 11, 2020
| if (process.platform !== 'win32') { | ||
| assert.equal(res[3], '9.9999999999999992e+22'); | ||
| } else { | ||
| assert.equal(res[3], '9.9999999999999992e+022'); |
Contributor
There was a problem hiding this comment.
@Salakar I guess this is an issue with Redis itself on Windows?
Contributor
Author
There was a problem hiding this comment.
Maybe, it was consistent across all Node versions and only occured on Windows.
I did make a note of one strange behaviour though, it only started showing up on the newer Windows version Server 2019, didn't show on 2018 as far as I remember.
I have a todo already to try repro on my Windows box over the weekend, so will let you know the outcome here.
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
Additionally adds testing against many Node.js versions and Redis versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpass with this change (including linting)?