Skip to content

Commit 16c8af4

Browse files
committed
Merge pull request #679 from candeira/fix-getitem
fix getitem syntax for redis get when value is the empty string
2 parents 2aeffb9 + e297528 commit 16c8af4

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

redis/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,7 @@ def __getitem__(self, name):
885885
doesn't exist.
886886
"""
887887
value = self.get(name)
888-
if value:
888+
if value is not None:
889889
return value
890890
raise KeyError(name)
891891

tests/test_commands.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,10 @@ def test_getitem_raises_keyerror_for_missing_key(self, r):
341341
with pytest.raises(KeyError):
342342
r['a']
343343

344+
def test_getitem_does_not_raise_keyerror_for_empty_string(self, r):
345+
r['a'] = b("")
346+
assert r['a'] == b("")
347+
344348
def test_get_set_bit(self, r):
345349
# no value
346350
assert not r.getbit('a', 5)

0 commit comments

Comments
 (0)