Skip to content

Conversation

@treeder
Copy link

@treeder treeder commented Jul 19, 2012

Symbolizes passed in options. All tests pass and created new tests for string options.

Closes #255.

@pietern
Copy link
Collaborator

pietern commented Jul 24, 2012

Thanks for submitting this pull request.

Symbolizing all keys in a hash is generally not a good idea, since it can contain anything, and symbols are not GC'd. This means that a large hash with keys unrelated to redis-rb will result in memory being used without purpose. I took a slightly different approach in #259, where only the keys that are used are symbolized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept string keys in the constructor/config hash

2 participants