Llmcache ttl configuration #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
commented
Jul 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 88.05% 88.56% +0.50%
==========================================
Files 11 11
Lines 536 551 +15
==========================================
+ Hits 472 488 +16
+ Misses 64 63 -1
|
Spartee
previously approved these changes
Aug 1, 2023
Contributor
Spartee
left a comment
Spartee
left a comment
There was a problem hiding this comment.
Minor comments. Looks great.
redisvl/index.py
Outdated
| for record in data: | ||
| key = f"{self._prefix}:{self._get_key_field(record)}" | ||
| self._redis_conn.hset(key, mapping=record) # type: ignore | ||
| # TODO -- should we return a count of the upserts? or some kind of metadata? |
Contributor
There was a problem hiding this comment.
Todo outside comments. these become docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables TTL for loading data to Redis using RedisVL. This TTL is an optional kwarg for the underlying
loadfunction. This is particularly useful for clients and abstractions like SemanticCache that lean on Redis support for ephemeral data.Also adds a
clearmethod to the LLM cache class that invalidates all data from the cache, but does not disturb the index itself.