Skip to content

Fixes flaky text word weights #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
+11 −4
Merged

Fixes flaky text word weights #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions tests/integration/test_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,10 @@ def test_text_query_word_weights(index, scorer):
text_field = "description"
return_fields = ["description"]

weights = {"medical": 3.4, "cancers": 5}
weights = {
"medical": 1.1,
"cancers": 1.15,
} # use small weights to not change results

# test we can run a query with text weights
weighted_query = TextQuery(
Expand All @@ -905,6 +908,7 @@ def test_text_query_word_weights(index, scorer):
return_fields=return_fields,
text_scorer=scorer,
text_weights=weights,
sort_by="description",
)

weighted_results = index.query(weighted_query)
Expand All @@ -917,14 +921,17 @@ def test_text_query_word_weights(index, scorer):
return_fields=return_fields,
text_scorer=scorer,
text_weights={},
sort_by="description",
)

unweighted_results = index.query(unweighted_query)

for weighted, unweighted in zip(weighted_results, unweighted_results):
for word in weights:
if word in weighted["description"] or word in unweighted["description"]:
assert weighted["score"] > unweighted["score"]
# test that the same results are returned when small weights are used
assert weighted["description"] == unweighted["description"]
# test the score still changes slightly with small weights
if any([word in weighted["description"] for word in weights]):
assert weighted["score"] > unweighted["score"]

# test that weights do change the document score and order of results
weights = {"medical": 5, "cancers": 3.4} # switch the weights
Expand Down