Rueidis adds 44 MB to build binary

[nightwolfz]

This eclipses every single other module my project is using combined.

Anything we can do about this?

[rueian]

Hi @nightwolfz,

I find this and this:
https://github.com/nikolaydubina/go-binsize-treemap
https://github.com/knz/go-binsize-viz

Would you like to try them to find out which part of rueidis occupies the most binary size?

[nightwolfz]

@rueian This is what I got

44 MB github.com/rueian/rueidis/internal/cmds using https://github.com/jondot/goweight

The SVG generated shows a different size, but this lib is still the heaviest one.

[rueian]

Hi @nightwolfz,

The internal/cmds contains the generated command builder. It is indeed very big due to the complexity of the redis command syntax.

However, normally you won't use all its generated code, and therefore the binary size after compilation won't be such big.

For example, the real binary size of the following program is 5.1MB on my laptop while goweight still insists that it should be at least 44MB:

package main

import (
	"context"
	"github.com/rueian/rueidis"
)

func main() {
	c, err := rueidis.NewClient(rueidis.ClientOption{})
	if err != nil {
		panic(err)
	}
	c.Do(context.Background(), c.B().FtSearch().Index("").Query("").Build())
}

Please also check this issue: jondot/goweight#16

[rueian]

Hi @nightwolfz,

Is the size problem still bothering you?

[nightwolfz]

@rueian It's not really a big issue. A barebone project is indeed only 6 MB, so there must be something I'm doing wrong.

I'll open a new issue if I figure it out.

[shushenghong]

after import rueidis, the binary size add more than 10MB, and i have used -ldflags=-w build flags

without rueidis

-rwxr-xr-x   1 shushenghong  staff    29M  3 29 15:42 main

with rueidis

-rwxr-xr-x   1 shushenghong  staff    38M  3 29 15:40 main

[palkan]

Hey there!

First of all, thanks for library. I've started migrating anycable-go to use ruedis and recently discovered that binary sizes increased by ~8MB (you can see the difference in the releases, between 1.3.0 and 1.4.0, I tested locally to confirm it's due to ruedis). I see a similar to above picture when running go-binsize-treemap, too:

I can't say going from 13MB to 21MB is a big concern, but it's noticeable.

normally you won't use all its generated code, and therefore the binary size after compilation won't be such big.

It doesn't seem that Go so smart to eliminate some of the code loaded from internal/cmds; it either all or nothing. I found that the following minimal rueidis usage results in the same binary size increase:

package pubsub

import (
	"sync"
	"github.com/redis/rueidis"
)

type RedisSubscriber struct {
	client        rueidis.Client
	clientOptions *rueidis.ClientOption
	clientMu      sync.RWMutex
}

func NewRedisSubscriber(args ...interface{}) (*RedisSubscriber, error) {
	return &RedisSubscriber{}, nil
}

func (s *RedisSubscriber) initClient() error {
	s.clientMu.Lock()
	defer s.clientMu.Unlock()

	if s.client != nil {
		return nil
	}

	c, err := rueidis.NewClient(*s.clientOptions)

	if err != nil {
		return err
	}

	s.client = c

	return nil
}

(Compiled with -ldflags="-s -w", of course)