Skip to content

Conversation

@henrydekap
Copy link

No description provided.

@codemedic
Copy link
Contributor

@henrydekap sorry about the late response; been busy lately.
I will review it as soon as I can.

@henrydekap
Copy link
Author

don't worry @codemedic, I don't have deadlines for this! 😃

@rbellido54
Copy link

Nice! Is there work needed to be done for the 2.0 branch as well?

@eventbase-web
Copy link

I'm eagerly awaiting this PR being merged. Anything I can do to help speed it along?

}
}

protected function loadDump($connector)
Copy link
Contributor

@codemedic codemedic Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPDoc Comments missing; but never mind I will add that this time :)

@codemedic
Copy link
Contributor

codemedic commented Jun 17, 2016

I have made some comments for the sake of clarity; I will make those changes and merge.
Nothing for you to act on @henrydekap

codemedic added a commit that referenced this pull request Jun 17, 2016
Split dump.sql into primary and secondary.
Made the example work with the sample database
@codemedic codemedic merged commit 06e19a5 into redmatter:1.0 Jun 17, 2016
codemedic added a commit that referenced this pull request Jun 17, 2016
* 2.0:
  Bringing 2.0 up to date with 1.0 changes from #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants