[v23.3.x] tx_migration: avoid ping pong of requests between brokers #15980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c760537)
When leader table is stale (say at startup or during failures), the current code can result in a ping pong of requests between two brokers in a tight loop. Example - tx_migration_replicate dispatched from node 1 to node 2 (because node 1 thinks node 2 is the leader) - node 2 dispatches the request back to node 1 because it thinks node 1 is the leader. Until leadership stabilizes this results in a huge pile up of requests which manifested as an oversized allocation. Don't think a router is the right choice in the handler as the handler is supposed to process the request locally. If it returns an error, it is propagated to the source router which dispatches to the correct leader. This also breaks the ping pong loop as the source router has sleeps induced for retry backoff. (cherry picked from commit a174ba2)
|
/ci-repeat |
piyushredpanda
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15953
Fixes: #15979,