[v22.2.x] rpk: do not modify redpanda.rpc_server_tls field (manual backport) #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpk now will treat this field like an unmanaged field, which means that we can have either a list, or an element, and rpk will respect that.
twmb
requested review from
a team,
r-vasquez,
gene-redpanda and
BenPope
as code owners
|
|
twmb
force-pushed
the
v22.2.x-rpc-tls-fix-v2
branch
2 times, most recently
from
94493fe to
2b7a0ec
Compare
twmb
force-pushed
the
v22.2.x-rpc-tls-fix-v2
branch
4 times, most recently
from
3f32172 to
afb06b2
Compare
If the rpc_tls_server config is a list rpk will do a TLS config validation and print a warning if the config is invalid.
twmb
force-pushed
the
v22.2.x-rpc-tls-fix-v2
branch
from
a6c25be to
f1fc4c2
Compare
|
Failure is #7756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of PR #7719
Fixes #7644
Release Notes
Bug Fixes
redpanda.rpc_server_tlsproperty when decoding the redpanda.yaml, which means that it will leave the field as a list or as an element depending on what the user has configured before executing rpk commands.