Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] admin: drop no-op user requests before writing to controller log #9856

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[v22.3.x] admin: drop no-op user requests before writing to controller log #9856

merged 2 commits into from
Apr 12, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #9842

@vbotbuildovich vbotbuildovich added this to the v22.3.x-next milestone Apr 5, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 5, 2023
@vbotbuildovich vbotbuildovich requested a review from ztlpn April 5, 2023 21:10
@jcsp jcsp marked this pull request as ready for review April 5, 2023 21:10
@Lazin Lazin mentioned this pull request Apr 6, 2023
Merged
7 tasks
@piyushredpanda piyushredpanda modified the milestones: v22.3.x-next, v22.3.16 Apr 10, 2023
@BenPope
Copy link
Member

BenPope commented Apr 10, 2023

Ping

@andrewhsu
Copy link
Member

i see error:

[ERROR:2023-04-05 22:03:35,299]: Failed to import rptest.tests.read_replica_e2e_test, which may indicate a broken test that cannot be loaded: NameError: name 'CloudStorageType' is not defined

but latest build job of v22.3.x branch is green. perhaps this PR needs a rebase?

@andrewhsu
Copy link
Member

@mergify rebase v22.3.x

jcsp added 2 commits April 10, 2023 19:58
@jcsp @andrewhsu
admin: skip controller writes for no-op user actions
3e47a01 
Clients should also avoid issuing these requests to begin
with, but in case of bad behavior, let's avoid generating
unnecessary writes to the controller log.

(cherry picked from commit b88f4a0)
@jcsp @andrewhsu
admin: redirect user writes to controller leader
b2d2ff1 
In order that our checks for no-op writes are correctly
ordered, we must execute these on the controller leader.
Otherwise we might incorrectly drop a write on another
node because its credential store is out of date.

(cherry picked from commit f47fb81)
@mergify
Copy link

mergify bot commented Apr 10, 2023

rebase v22.3.x

✅ Branch has been successfully rebased

@andrewhsu andrewhsu force-pushed the backport-fixes-to-v22.3.x-439 branch from bfbcee9 to b2d2ff1 Compare April 10, 2023 19:58
@ballard26
Copy link
Contributor

ballard26 commented Apr 12, 2023 •
edited
Loading

The CI failures are;

None of these look to be related to the PR its self so we're probably safe to merge.

@piyushredpanda piyushredpanda merged commit b8905d3 into redpanda-data:v22.3.x Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ballard26 ballard26 ballard26 approved these changes

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees

@jcsp jcsp

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.3.16
Development

Successfully merging this pull request may close these issues.
6 participants
@vbotbuildovich @BenPope @andrewhsu @ballard26 @jcsp @piyushredpanda