Skip to content

Commit 24472cb

Browse files
author
Dmitry Sobolev
committed
Merge branch 'old'
Conflicts: feedback/__init__.py feedback/templatetags/feedback_tags.py
2 parents c1ffe18 + 7d87ea7 commit 24472cb

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

feedback/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# -*- coding: utf-8 -*-
2-
__version__ = '0.3.9.1'
2+
__version__ = '0.3.10'
33

feedback/templatetags/feedback_tags.py

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,32 @@
1-
# -*- coding: utf-8 -*-
1+
#-*- coding: utf-8 -*-
22

3+
from classytags.arguments import Argument
4+
from classytags.core import Tag, Options
35
from django import template
4-
from django.forms import BooleanField
5-
from django.utils.translation import ugettext_lazy as _
6-
from django.template import loader
6+
from django.template.loader import render_to_string
77
from django.template.context import RequestContext
8-
8+
from django.utils.translation import gettext_lazy as _
99
from feedback.utils import get_feedback_form
10+
from feedback.settings import DEFAULT_FORM_KEY
11+
from django.forms.fields import BooleanField
1012

1113
register = template.Library()
1214

13-
14-
@register.simple_tag(takes_context=True)
15-
def show_feedback(context, key='default'):
16-
form = get_feedback_form(key)()
17-
t = loader.select_template([
18-
'feedback/%s/feedback.html' % key,
19-
'feedback/feedback.html',
20-
])
21-
request_context = RequestContext(context['request'], locals())
22-
output = t.render(request_context)
23-
return output
24-
15+
class ShowFeedback(Tag):
16+
name = 'show_feedback'
17+
18+
options = Options(Argument('form_key', required=False, resolve=False))
19+
20+
def render_tag(self, context, form_key):
21+
form_key = form_key if form_key else DEFAULT_FORM_KEY
22+
form = get_feedback_form(form_key)()
23+
24+
return render_to_string([
25+
'feedback/%s/feedback.html' % form_key,
26+
'feedback/feedback.html',
27+
], {'form':form}, context_instance=RequestContext(context['request']))
28+
29+
register.tag(ShowFeedback)
2530

2631
@register.filter
2732
def get_choice_value(bound_field):

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def read(fname):
3838
'Topic :: Internet :: WWW/HTTP :: Dynamic Content',
3939
],
4040
packages=find_packages(),
41-
install_requires=[],
41+
install_requires=['django-classy-tags >=0.3,<0.4'],
4242
include_package_data=True,
4343
zip_safe=False,
4444
long_description=read('README'),

0 commit comments

Comments
 (0)