Skip to content

Commit fdca9a5

Browse files
committed
Merge pull request #4 from a-iv/master
django 1.4 compatible
2 parents 1063cea + 8f5afd3 commit fdca9a5

File tree

6 files changed

+31
-19
lines changed

6 files changed

+31
-19
lines changed

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
recursive-include feedback/media *.js *.css
1+
recursive-include feedback/static *.js *.css
22
recursive-include feedback/templates *.html *.txt
33
recursive-include feedback/locale *.po *.mo
44
include README README.rst DESCRIPTION INSTALL.txt

feedback/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# -*- coding: utf-8 -*-
2-
__version__ = '0.3.7'
2+
__version__ = '0.3.8'
33

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
{% load i18n feedback_tags %}
2-
{{ subject }}
1+
{% load i18n feedback_tags %}{{ subject }}
32
==============
43

5-
{% for field in form %}
6-
{% ifnotequal field.name 'form_settings_key' %}
7-
{{ field.label }}: {{ field|get_choice_value }}
8-
{% endifnotequal %}
9-
{% endfor %}
10-
4+
{% for field in form %}{% ifnotequal field.name 'form_settings_key' %}{{ field.label }}: {{ field|get_choice_value }}
5+
{% endifnotequal %}{% endfor %}
116
{% trans "Form type" %}: {{ form.subject }}

feedback/templatetags/feedback_tags.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
11
# -*- coding: utf-8 -*-
2+
23
from django import template
3-
from django.template import loader, Context
44
from django.forms import BooleanField
5-
from feedback.utils import get_feedback_form
65
from django.utils.translation import ugettext_lazy as _
6+
from django.template import loader
7+
from django.template.context import RequestContext
8+
9+
from feedback.utils import get_feedback_form
710

811
register = template.Library()
912

1013

11-
@register.simple_tag
12-
def show_feedback(key='default'):
14+
@register.simple_tag(takes_context=True)
15+
def show_feedback(context, key='default'):
1316
form = get_feedback_form(key)()
1417
t = loader.select_template([
1518
'feedback/%s/feedback.html' % key,
1619
'feedback/feedback.html',
1720
])
18-
output = t.render(Context(locals()))
21+
request_context = RequestContext(context['request'], locals())
22+
output = t.render(request_context)
1923
return output
2024

2125

feedback/urls.py

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,25 @@
11
# -*- coding: utf-8 -*-
2+
23
from django.conf.urls.defaults import *
4+
35
from feedback.settings import DIRECT_TO_TEMPLATE
46

7+
58
if DIRECT_TO_TEMPLATE:
6-
urlpatterns = patterns('django.views.generic.simple',
7-
url(r'^$', 'direct_to_template',
8-
{'template': 'feedback/feedback_page.html'}, name='feedback_page')
9-
)
9+
try:
10+
from django.views.generic import TemplateView
11+
except ImportError:
12+
urlpatterns = patterns('django.views.generic.simple',
13+
url(r'^/$', 'direct_to_template',
14+
{'template': 'feedback/feedback_page.html'},
15+
name='feedback_page'))
16+
else:
17+
urlpatterns = patterns('',
18+
url(r'^/$',
19+
TemplateView.as_view(
20+
template_name='feedback/feedback_page.html'),
21+
name='feedback_page')
22+
)
1023
else:
1124
urlpatterns = patterns('')
1225

0 commit comments

Comments
 (0)