Form still dirty after `initialize(formName, newData, true)`

[ncphillips]

We're using redux form to edit some pages, and I'm having some trouble re-initializing the form after saving.

The submit callback is

const mapDispatchToProps = (dispatch) => ({
 submit: (page) => dispatch(updatePage(page)).then((page) => {
      dispatch(initialize(`page/${page.slug}`, page, false));
      dispatch(reset(`page/${page.slug}`));
      return page;
    });
});

This seems to be working as expected. The current and initial values for the form are equal, however the dirty flag is set to 'true' until I reload the page.

Any ideas on why this might be happening?

This seems to be effecting the state as I expected, the form values stay the same, but the

[ncphillips]

I also have a button to manually reset the form, and I just noticed that after this runs that button no longer effects the form.

[ncphillips]

Here's a test describing the expected behaviour

it.only('should not be dirty after initialize()', () => {
      const store = makeStore({})
      const input = createSpy(props => <input {...props.input}/>).andCallThrough()

      const Form = createSpy((props) => (
        <form>
          <Field name="bar" component={input} type="text"/>
        </form>
      )).andCallThrough()

      const Decorated = reduxForm({
        form: 'testForm',
        initialValues: { bar: 'initialBar' }
      })(Form)

      const dom = TestUtils.renderIntoDocument(
        <Provider store={store}>
          <Decorated/>
        </Provider>
      )

      const stub = TestUtils.findRenderedComponentWithType(dom, Decorated)

      inputOnNthRender(input, 0).onChange('newBar')

      expect(propsOnNthRender(Form, 1).dirty).toBe(true)

      store.dispatch(initialize('testForm', { bar : 'newBar' }))

      expect(propsOnNthRender(Form, 1).dirty).toBe(false)
    })

[skolmer]

@ncphillips let's create a fork/PR containing this test. I will help to work on a solution later this week. will add a test to tackle the reset issue I have reported in #1776

[ncphillips]

Thanks @skolmer, I actually figured out how to make it work, but it broke a couple tests that were relying on render counting to validate their behaviour. I'll fork the project and submit a PR here shortly.

[erikras]

Fix published in v6.2.0.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.