fix(reducer/change): allow change to handle undefined payload

[tnrich]

Closes #3946

[codecov]

Codecov Report

Merging #4507 into master will decrease coverage by 1.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
- Coverage     100%   98.96%   -1.04%     
==========================================
  Files          74       74              
  Lines        1744     1743       -1     
==========================================
- Hits         1744     1725      -19     
- Misses          0       18      +18

Impacted Files	Coverage Δ
src/createReducer.js	100% <100%> (ø)	⬆️
src/createReduxForm.js	93.88% <0%> (-6.12%)	⬇️
src/handleSubmit.js	98.48% <0%> (-1.52%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d4e0b...4063e50. Read the comment docs.

[tnrich]

@iamandrewluca I tried to make the changes but I'm not sure if I got them all. Could you let me know if I need to make anymore?

[tnrich]

Also, @iamandrewluca it looks like the tests are failing for an unrelated error:

    console.error node_modules/jsdom/lib/jsdom/virtual-console.js:29
      Error: Uncaught [Error: Fields must be inside a component decorated with reduxForm()]

Maybe I need to merge in the latest commits on master?

[unrevised6419]

@tnrich those are just console.error from code, they are expected. I think we should run tests in silent mode to have a more cleaner output.

[tnrich]

Okay awesome I applied your suggestions. Thanks! Is it all ready to go now?

[unrevised6419]

@tnrich yeap, we just need to wait for an project collaborator :)

[tnrich]

Perfect thanks so much! I hope it'll go through!

[unrevised6419]

Would be great to have title more descriptive, may catch collaborators eyes

fix(reducer/change): allow `change` to handle `undefined` payload

and include in body

Closes #3946

https://help.github.com/en/articles/closing-issues-using-keywords

[unrevised6419]

Also I would opt to deprecate using this initial === undefined && payload === '' in change.
This allows only to clean field when initial value is undefined.
User should take care to what value is changing.

[tnrich]

Also I would opt to deprecate using this initial === undefined && payload === '' in change.
This allows only to clean field when initial value is undefined.
User should take care to what value is changing.

How should I go about doing that? @iamandrewluca

[unrevised6419]

Wi'll think of that in a future refactor.

[renatoagds]

Published in v8.2.6.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.