Skip to content

Avoid allocating a redundant function in the Provider #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Avoid allocating a redundant function in the Provider #1857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function Provider<A extends Action = AnyAction>({
}
}, [store, serverState])

const previousState = useMemo(() => store.getState(), [store])
const previousState = useMemo(store.getState, [store])
Copy link
Contributor Author

@Andarist Andarist Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it breaks custom stores that rely on this. A test covering this use case was originally introduced here and fixed this issue

Given how rare of a use case this is and the allocation cost that this requires for all users I would say that it would be better to drop support for this use case and require users who need this to bind their stores appropriately. It's an easy thing to do and feels to me like something that can be easily handled in the userland.

OTOH Provider itself is, at least currently, usually not rendered often as it lives "on the top" of the app. So kinda 🤷

Copy link
Contributor

@markerikson markerikson Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically Provider is only ever going to render once in an app anyway. Given that, I'm not sure this change really provides any benefit :)


useIsomorphicLayoutEffect(() => {
const { subscription } = contextValue
Expand Down