Throw if no component is passed to connect #436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return function wrapWithConnect(WrappedComponent) { | ||
| invariant( | ||
| typeof WrappedComponent == 'function', |
foiseworth
pushed a commit
to foiseworth/react-redux
that referenced
this pull request
Jul 30, 2016
typo fixes in docs
Member
|
Superseded by #416 |
aikoven
pushed a commit
to aikoven/react-redux
that referenced
this pull request
Nov 21, 2016
neeharv
pushed a commit
to neeharv/react-redux
that referenced
this pull request
Feb 18, 2017
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you fail to pass a component to the function returned by
connectit fails in a confusing way (usuallyinst.render is not a function) that can be hard to track down if you're new to Redux.This PR adds a check, making sure a function is passed to
connect, throwing a useful error if not.