Skip to content

exposes new features to the API #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2016
Merged

exposes new features to the API #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/connect/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,9 @@ export function buildConnectOptions(
mergePropsFactories = defaultMergePropsFactories,
selectorFactory = defaultSelectorFactory,
pure = true,
__ENABLE_SECRET_EXPERIMENTAL_FEATURES_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = false,
...options
} = {}
) {
if (!__ENABLE_SECRET_EXPERIMENTAL_FEATURES_DO_NOT_USE_OR_YOU_WILL_BE_FIRED) {
mapStateToPropsFactories = defaultMapStateToPropsFactories
mapDispatchToPropsFactories = defaultMapDispatchToPropsFactories
mergePropsFactories = defaultMergePropsFactories
selectorFactory = defaultSelectorFactory
options = { withRef: options.withRef }
}

const initMapStateToProps = match(mapStateToProps, mapStateToPropsFactories)
const initMapDispatchToProps = match(mapDispatchToProps, mapDispatchToPropsFactories)
const initMergeProps = match(mergeProps, mergePropsFactories)
Expand Down
3 changes: 2 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Provider from './components/Provider'
import connectAdvanced from './components/connectAdvanced'
import connect from './connect/connect'

export { Provider, connect }
export { Provider, connectAdvanced, connect }
3 changes: 1 addition & 2 deletions test/components/connect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,8 +2001,7 @@ describe('React', () => {
})

it('should allow custom displayName', () => {
// TODO remove __ENABLE_SECRET_EXPERIMENTAL_FEATURES_DO_NOT_USE_OR_YOU_WILL_BE_FIRED once approved
@connect(null, null, null, { getDisplayName: name => `Custom(${name})`, __ENABLE_SECRET_EXPERIMENTAL_FEATURES_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: true })
@connect(null, null, null, { getDisplayName: name => `Custom(${name})` })
class MyComponent extends React.Component {
render() {
return <div></div>
Expand Down