fetchNextPage/fetchPreviousPage from infinite queries aren't referentially stable.

[zernie]

This causes constant unwanted re-renders in the components that use these hooks.

[EskiMojo14]

could you make a reproduction of this? the functions are already wrapped in useMemos where required, and changes in references shouldn't actually cause rerenders - only changes in state.

[zernie]

@EskiMojo14 sorry, what do you mean by changes in state? incoming data from server, args?

[zernie]

Looks like the issue was with args : they weren't referentially stable.

This is surprising - I thought args get serialized anyway so I don't need an additional memorization before passing args to use...Infinite hook. is this intentional?

[EskiMojo14]

@EskiMojo14 sorry, what do you mean by changes in state? incoming data from server, args?

https://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-guide-to-react-rendering-behavior/#queuing-renders

Looks like the issue was with args weren't being preferentially stable. This is surprising - I thought args get serialized anyway so I don't need an additional memorization before passing args to use...Infinite hook. is this intentional?

ah, that makes sense - looks like some of the memoisation is still happening based on referential equality. I'll raise a PR for that

[zernie]

@EskiMojo14 this is incredible. thanks!

[zernie]

@markerikson @EskiMojo14 hey, any idea as to when this is going to be shipped? Thanks again!

[markerikson]

It'll be out in 2.7.0. Hoping to get that out the door in the next few days.