Skip to content

docs: Fix grammatical error in part-6-performance-normalization.md #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
+1 −1
Merged

docs: Fix grammatical error in part-6-performance-normalization.md #4816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/tutorials/essentials/part-6-performance-normalization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,7 +1298,7 @@ The only action we're handling here always replaces the entire list of users wit

We were already exporting the `selectAllUsers` and `selectUserById` selectors we'd written by hand. We can replace those with the versions generated by `usersAdapter.getSelectors()`.

We do now have a slight types mismatch with `selectUserById` - our `currentUsername` _can_ be `null` according to the types, but the generated `selectUserById` won't accept that. A simple fix is to check if exists and just return early if it doesn't.
We do now have a slight types mismatch with `selectUserById` - our `currentUsername` _can_ be `null` according to the types, but the generated `selectUserById` won't accept that. A simple fix is to check if it exists and just return early if it doesn't.

### Normalizing the Notifications Slice

Expand Down