Test shallowEquality #98
Conversation
There was a problem hiding this comment.
This is dead code. This is already present in the if statement.
|
The file should be named |
|
@emmenko Okay.Sorry I didn't notice it. |
|
Np :) |
test/utils/shallowEquality.js
Outdated
There was a problem hiding this comment.
Let's only test things whose typeof is object. This includes null, but not undefined.
test/utils/shallowEquality.spec.js
Outdated
There was a problem hiding this comment.
@gaearon I don't know how to concisely describe shallowEqualScalar. Help please? or just leave it be since I have left the comment?
There was a problem hiding this comment.
“should compare shallowly but bail out on object fields”
test/utils/shallowEquality.spec.js
Outdated
There was a problem hiding this comment.
Please tweak the style to use spaces inside object definitions. ({a : 1} => { a: 1 }). This doesn't concern arrays, just objects.
|
@gaearon Can you take a look now ? |
|
Currently the following test fails: expect(shallowEqual({a: NaN}, {a: NaN})).toBe(true)Maybe we should fix that. |
src/utils/shallowEqual.js
Outdated
There was a problem hiding this comment.
Can you remove this line?
|
@ooflorent Done. Anything else? |
4 participants
No description provided.