Left side tabs #2734
Merged
Left side tabs #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parndt
force-pushed
the
left-side-tabs
branch
2 times, most recently
from
e524b47
to
fb2f8f1
Compare
|
Here's what it currently looks like:
|
|
👍 (just for screenshot, not tested yet) |
|
Something's weird about the buttons, might have been my changes though and not @isaacfreeman's fault. |
|
Having a look. I think it's be good to restore some rounded corners to the tabs too, so people don't hurt themselves. |
Closed
|
Could we reduce padding-top above the flash notice in order to be equal to the padding-left|right of the page content ? |
|
@bricesanchez: Good call, will do. |
|
Hello ! Could I help you to finish this feature ? |
|
@bricesanchea: That'd be great, thanks. |
Having admin tabs at the top running horizontally means they have to fit into a finite space. If there are too many, they go into a carousel, which is very inconvenient for navigation, and makes the rightmost tabs invisible to users. I've put the admin tabs vertically at the left of the admin area. This gives as much vertical space (with scrolling) as needed. - positioned admin tabs vertically at left - wrapped admin content in #admin_container div - corresponding #login_container div for login page - more rounded corner mixins - box-sizing mixin - admin_background mixing provides faux column gradient background for admin area (modern browsers and IE10 up) - SASS variables for $menu_width and $standard_rounding - sortable_menu.js setting changed to y axis - removed jcarousel and images Conflicts: core/app/assets/images/refinery/carousel-left.png core/app/assets/images/refinery/carousel-right.png core/app/assets/stylesheets/refinery/layout.css.scss
…ht.png - moved SASS utility mixins to a separate file - generalised admin_background() mixin to faux_columns_2() Conflicts: core/app/assets/stylesheets/refinery/layout.css.scss
- Removed admin rounding. - Gave menu a defined background. - Changed width of search box.
parndt
force-pushed
the
left-side-tabs
branch
from
0ed1ebc
to
afca0bc
Compare
Conflicts: core/app/assets/stylesheets/refinery/layout.css.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts, comments? @isaacfreeman