Refactorcop refactors

[parndt]

This could be a work in progress, please contribute to this branch refactorcop if you want to address these issues one by one:

http://www.refactorcop.com/refinery/refinerycms

[gogogarrett]

Should we add a rubocop.yml file to the project that everyone should abide by when contributing?

[parndt]

@gogogarrett Yeah, potentially! Are you willing to handle that? It'd be great if we could see this sort of information when a pull request is opened, like a build fail/pass.

[simi]

I'm not a fan of this :(

[parndt]

@simi it's not like we have to reject PRs outright, it's just nice to have the information. Refactor cop isn't intended to be followed 100%, it's just to promote discussion around code maintenance and technical debt introduction.

[simi]

@parndt actually I changed my mind. Are you still interested in merge? Rebase would be needed anyway.

[parndt]

@simi rebased

[simi]

Sorry for obstructions @parndt.

[parndt]

❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️❤️💛💙💜💚💜💙💛❤️💛💙💜💚💜💙💛❤️