Added better support for :at Rails mount option.
#2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done via changing `Refinery::Core.config.mounted_path` which is located inside `config/initializers/refinery/core.rb` in an application which has Refinery. Fixes #2740
parndt
force-pushed
the
feature/refinery-subfolder-issue-2740
branch
from
3053a76
to
099b750
Compare
|
I think this is good for now, but it is not a 100% Rails way. |
|
What would be the 100% Rails way? |
|
IMHO make Frontend and Backend as separated engines and allow to mount them separately when needed or mount "meta-engine" for both at once. But as I wrote before, this is ok for now. |
simi
added a commit
that referenced
this pull request
Jan 26, 2015
…ue-2740 Added better support for `:at` Rails mount option.
|
Ah, yes, well @bricesanchez is working on making it better over at #2811 😄 |
| @@ -219,10 +219,11 @@ def mount! | |||
| mount = %Q{ | |||
| # This line mounts Refinery's routes at the root of your application. | |||
| # This means, any requests to the root URL of your application will go to Refinery::PagesController#home. | |||
| # If you would like to change where this extension is mounted, simply change the :at option to something different. | |||
| # If you would like to change where this extension is mounted, simply change the | |||
| # configuration option `mounted_path` to something different in config/initializers/refinery/core.rb | |||
| # | |||
| # We ask that you don't use the :as option here, as Refinery relies on it being the default of "refinery" | |||
There was a problem hiding this comment.
Is this still the case?
There was a problem hiding this comment.
Yes, unless you can find a way to work around it. We reference refinery.path_helper everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e.
Fixes #2740