Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert ae30517 : Remove layout def, we use render_with_templates? method #3384

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

bricesanchez
Copy link
Member

It was a bad idea, it breaks the preview layout.

render_with_templates? will use the default layout 'application' or the @page.layout_template

…tes? method

It was a bad idea, it breaks the preview layout.

render_with_templates? will use the default layout 'application' or the @page.layout_template
@bricesanchez bricesanchez changed the title Revert Remove layout def, we use render_with_templates? method Partial revert ae30517 : Remove layout def, we use render_with_templates? method Jul 26, 2018
@bricesanchez bricesanchez requested a review from parndt July 26, 2018 02:52
@parndt parndt merged commit cd8dfdc into master Jul 26, 2018
@bricesanchez bricesanchez added this to the 5.0 milestone Jul 27, 2018
@bricesanchez bricesanchez deleted the bugfix/preview_layout branch August 21, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants