Skip to content

fix: make stop propagated event listeners passive #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swiftwork merged 2 commits into from
Aug 13, 2025
Merged

fix: make stop propagated event listeners passive #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6892755
fix: make stop propagated event listeners passive
Swiftwork Aug 13, 2025
deda071
chore: update yarn lock
Swiftwork Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser-sdk/example/feedback/feedback.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<title>Bucket feedback collection</title>
<script src="https://cdn.jsdelivr.net/npm/@bucketco/browser-sdk@1"></script>
<script src="https://cdn.jsdelivr.net/npm/@bucketco/browser-sdk@latest"></script>
<style>
fieldset label {
display: flex;
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bucketco/browser-sdk",
"version": "3.3.2",
"version": "3.3.3",
"packageManager": "yarn@4.1.1",
"license": "MIT",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-sdk/src/feedback/ui/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function attachDialogContainer() {
document.body.appendChild(container);

for (const event of propagatedEvents) {
container.addEventListener(event, stopPropagation);
container.addEventListener(event, stopPropagation, { passive: true });
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/browser-sdk/src/ui/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function attachContainer(containerId: string) {
document.body.appendChild(container);

for (const event of propagatedEvents) {
container.addEventListener(event, stopPropagation);
container.addEventListener(event, stopPropagation, { passive: true });
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/openfeature-browser-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bucketco/openfeature-browser-provider",
"version": "0.6.1",
"version": "0.6.2",
"packageManager": "yarn@4.1.1",
"license": "MIT",
"repository": {
Expand Down Expand Up @@ -35,7 +35,7 @@
}
},
"dependencies": {
"@bucketco/browser-sdk": "3.3.1"
"@bucketco/browser-sdk": "3.3.3"
},
"devDependencies": {
"@bucketco/eslint-config": "0.0.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bucketco/react-sdk",
"version": "3.3.1",
"version": "3.3.2",
"license": "MIT",
"repository": {
"type": "git",
Expand Down Expand Up @@ -34,7 +34,7 @@
}
},
"dependencies": {
"@bucketco/browser-sdk": "3.3.1",
"@bucketco/browser-sdk": "3.3.3",
"canonical-json": "^0.0.4",
"rollup": "^4.2.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/vue-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bucketco/vue-sdk",
"version": "0.2.0",
"version": "0.2.1",
"license": "MIT",
"repository": {
"type": "git",
Expand Down Expand Up @@ -34,7 +34,7 @@
}
},
"dependencies": {
"@bucketco/browser-sdk": "3.2.0",
"@bucketco/browser-sdk": "3.3.3",
"canonical-json": "^0.2.0"
},
"peerDependencies": {
Expand Down
32 changes: 4 additions & 28 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,31 +671,7 @@ __metadata:
languageName: node
linkType: hard

"@bucketco/browser-sdk@npm:3.2.0":
version: 3.2.0
resolution: "@bucketco/browser-sdk@npm:3.2.0"
dependencies:
"@floating-ui/dom": "npm:^1.6.8"
canonical-json: "npm:^0.0.4"
js-cookie: "npm:^3.0.5"
preact: "npm:^10.22.1"
checksum: 10c0/4663b213f24a1ba7f2878751606cd32752c477ca192fda5a264c6a27d4c6a2db9e4f3a5422bf45bb8ba6c24c2b5249def19f425243d3d754fde0d92231f35562
languageName: node
linkType: hard

"@bucketco/browser-sdk@npm:3.3.1":
version: 3.3.1
resolution: "@bucketco/browser-sdk@npm:3.3.1"
dependencies:
"@floating-ui/dom": "npm:^1.6.8"
canonical-json: "npm:^0.0.4"
js-cookie: "npm:^3.0.5"
preact: "npm:^10.22.1"
checksum: 10c0/30bd1fa0f084c7eee0a22f917bfe488667243013711787bc36c9befa0d3aa27a4aed6f0576416a098b3d3d64ff1cf873587022d4d9c07198e11d4f81f31380de
languageName: node
linkType: hard

"@bucketco/browser-sdk@workspace:packages/browser-sdk":
"@bucketco/browser-sdk@npm:3.3.3, @bucketco/browser-sdk@workspace:packages/browser-sdk":
version: 0.0.0-use.local
resolution: "@bucketco/browser-sdk@workspace:packages/browser-sdk"
dependencies:
Expand Down Expand Up @@ -824,7 +800,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@bucketco/openfeature-browser-provider@workspace:packages/openfeature-browser-provider"
dependencies:
"@bucketco/browser-sdk": "npm:3.3.1"
"@bucketco/browser-sdk": "npm:3.3.3"
"@bucketco/eslint-config": "npm:0.0.2"
"@bucketco/tsconfig": "npm:0.0.2"
"@openfeature/core": "npm:1.5.0"
Expand Down Expand Up @@ -870,7 +846,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@bucketco/react-sdk@workspace:packages/react-sdk"
dependencies:
"@bucketco/browser-sdk": "npm:3.3.1"
"@bucketco/browser-sdk": "npm:3.3.3"
"@bucketco/eslint-config": "workspace:^"
"@bucketco/tsconfig": "workspace:^"
"@testing-library/react": "npm:^15.0.7"
Expand Down Expand Up @@ -911,7 +887,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@bucketco/vue-sdk@workspace:packages/vue-sdk"
dependencies:
"@bucketco/browser-sdk": "npm:3.2.0"
"@bucketco/browser-sdk": "npm:3.3.3"
"@bucketco/eslint-config": "workspace:^"
"@bucketco/tsconfig": "workspace:^"
"@types/jsdom": "npm:^21.1.6"
Expand Down