Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 23, 2021

Closes #1917.
Closes #1918.
Closes #2017.

@vkarak vkarak added this to the ReFrame Sprint 21.07.1 milestone Jul 23, 2021
@vkarak vkarak requested review from ekouts, jjotero and teojgo July 23, 2021 20:21
@vkarak vkarak self-assigned this Jul 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #2096 (44c1f33) into 4.x (d2c12f1) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 44c1f33 differs from pull request most recent head bcbdc52. Consider uploading reports for the commit bcbdc52 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              4.x    #2096      +/-   ##
==========================================
+ Coverage   86.80%   87.03%   +0.22%     
==========================================
  Files          52       52              
  Lines        9232     9137      -95     
==========================================
- Hits         8014     7952      -62     
+ Misses       1218     1185      -33     
Impacted Files Coverage Δ
reframe/core/pipeline.py 92.43% <ø> (+0.44%) ⬆️
reframe/utility/sanity.py 97.76% <ø> (-0.03%) ⬇️
reframe/core/decorators.py 88.33% <100.00%> (+24.04%) ⬆️
reframe/utility/versioning.py 95.23% <100.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c12f1...bcbdc52. Read the comment docs.

Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There are some references to rfm.run_after in reframe/core/launchers, reframe/core/schedulers/__init__.py and reframe/utility/__init__.py that still need to be changed. They are part of documentation.
  2. I see a lot of tests using the parameterized_test decorator in the branch. These should be fixed in a different PR, right?
  3. There are also many tests using the @sn.sanity_function decorator in the branch. Different PR as well?

@vkarak
Copy link
Contributor Author

vkarak commented Jul 26, 2021

@ekouts I will fix (1). I guess that by saying "tests," you mean ReFrame tests, not unit tests. These should be fixed in different PRs.

@vkarak vkarak requested a review from ekouts July 26, 2021 19:15
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 1335b8f into reframe-hpc:4.x Jul 27, 2021
@vkarak vkarak deleted the feat/remove-4.x-deprecated-feats branch July 27, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants