-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Remove deprecated features for 4.x #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Remove deprecated features for 4.x #2096
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.x #2096 +/- ##
==========================================
+ Coverage 86.80% 87.03% +0.22%
==========================================
Files 52 52
Lines 9232 9137 -95
==========================================
- Hits 8014 7952 -62
+ Misses 1218 1185 -33
Continue to review full report at Codecov.
|
jjotero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are some references to
rfm.run_afterinreframe/core/launchers,reframe/core/schedulers/__init__.pyandreframe/utility/__init__.pythat still need to be changed. They are part of documentation. - I see a lot of tests using the
parameterized_testdecorator in the branch. These should be fixed in a different PR, right? - There are also many tests using the
@sn.sanity_functiondecorator in the branch. Different PR as well?
|
@ekouts I will fix (1). I guess that by saying "tests," you mean ReFrame tests, not unit tests. These should be fixed in different PRs. |
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #1917.
Closes #1918.
Closes #2017.