Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 5, 2022

This PR exposes several Job attributes publicly by practically documenting them. It also uses the variable builtin to define them and also refactors a bit the arguments passed to the constructor of a Job. Now, the arguments that are passed to it are only those that must be set from the frontend either directly or indirectly through the configuration.

Fixes #2315.

@vkarak vkarak added this to the ReFrame Sprint 22.02.2 milestone Mar 5, 2022
@vkarak vkarak requested review from ekouts and teojgo March 5, 2022 22:44
@vkarak vkarak self-assigned this Mar 5, 2022
@vkarak vkarak changed the title [feat] Extend Job public API [feat] Extend public API of Job Mar 5, 2022
@vkarak vkarak changed the title [feat] Extend public API of Job [feat] Extend the public API of Job Mar 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #2463 (3449656) into master (7b27cbe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2463   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          56       56           
  Lines       10536    10529    -7     
=======================================
- Hits         9031     9025    -6     
+ Misses       1505     1504    -1     
Impacted Files Coverage Δ
reframe/core/launchers/mpi.py 98.90% <100.00%> (ø)
reframe/core/pipeline.py 93.38% <100.00%> (+0.01%) ⬆️
reframe/core/schedulers/__init__.py 98.28% <100.00%> (+0.45%) ⬆️
reframe/core/schedulers/lsf.py 48.75% <100.00%> (ø)
reframe/core/schedulers/slurm.py 52.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b27cbe...3449656. Read the comment docs.

@vkarak vkarak requested a review from teojgo March 7, 2022 20:46
@vkarak vkarak merged commit fd8ef4b into reframe-hpc:master Mar 8, 2022
@vkarak vkarak deleted the doc/job-attrs branch March 8, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document all of the Job attributes

4 participants