Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Jun 28, 2022

Closes #2499

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vkarak vkarak changed the title [feat] Take extra_resources into account for the build job [feat] Use the test's extra_resources also for the build job Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2547 (8e864ac) into master (431ca17) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8e864ac differs from pull request most recent head a2d96a8. Consider uploading reports for the commit a2d96a8 to get more accurate results

@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
- Coverage   86.04%   86.03%   -0.01%     
==========================================
  Files          59       59              
  Lines       11025    11030       +5     
==========================================
+ Hits         9486     9490       +4     
- Misses       1539     1540       +1     
Impacted Files Coverage Δ
reframe/core/pipeline.py 93.09% <100.00%> (+0.04%) ⬆️
reframe/frontend/executors/policies.py 92.30% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431ca17...a2d96a8. Read the comment docs.

@vkarak vkarak merged commit 64bfe9f into reframe-hpc:master Jul 12, 2022
@rsarm rsarm deleted the job-extra-resources branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support setting the number requested GPUs in a CompileOnlyRegressionTest

3 participants